-
Notifications
You must be signed in to change notification settings - Fork 317
Make 0px channels eligible for "stop" check #3942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is this a spec change? |
|
Going to check. |
|
(sorry, only old spec is at hands reach now) C.4.8: C.8.2: C.9.2: So, both C.4.8 and C.8.2 add "extra" condition on the top of C.9. C.9.2 gives a lower level hint - "no pixels -> skip". But of course, that could be interpreted the other way round. |
|
@jonsneyers friendly ping |
|
I mean: are there files produced by older cjxl/libjxl that will no longer decode if this gets merged, or will the new cjxl/libjxl produce files that will not decode by older djxl/libjxl? |
|
Current encoder and decoder fail when they meet specific input (very tall/wide image + modular + group-shift). Context: #3937 |
|
OK, let's just check if this is something that needs to be made more clear in the spec. |
Before this PR 0px channels were "skipped" before the check. In some cases 1xK and Kx1 images are squeezed (for 420 subsampling) and thus 0xK / Kx0 channels appear.
Pull Request is not mergeable
Before this PR 0px channels were "skipped" before the check. In some cases 1xK and Kx1 images are squeezed (for 420 subsampling) and thus 0xK / Kx0 channels appear.