这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@eustas
Copy link
Contributor

@eustas eustas commented Nov 19, 2024

No description provided.

@eustas eustas requested a review from szabadka November 19, 2024 11:11
@eustas eustas enabled auto-merge November 19, 2024 11:11
@jonsneyers
Copy link
Member

Changing the default Squeeze script seems risky, aren't there cases where this leads to jxl files no longer decoding?

@eustas
Copy link
Contributor Author

eustas commented Nov 20, 2024

This has been found by streaming_fuzzer; it crashes, because channel is "moved" to groups, but later on it still formally eligible for decoding into it.

Will check if crashes cjxl as well.

Code change only affects 1xK and Kx1 images; if those do not encode normally, then the change is considered safe (as there are no such encoded images in the wild).

@eustas
Copy link
Contributor Author

eustas commented Nov 20, 2024

Repro:

convert -size 1x1025 xc: narrow.png
./build/tools/cjxl -m 1 -g 3 ./narrow.png ./narrow.jxl

Result:

JPEG XL encoder v0.12.0 d28c7a24 [AVX2,SSE4,SSE2]
Encoding [Modular, d1.000, effort: 7]
lib/jxl/image.h:101: JXL_DASSERT: y < ysize_
Illegal instruction

Also with -g 2; but OK with -g 1 and -g 0

@eustas eustas closed this Nov 20, 2024
auto-merge was automatically disabled November 20, 2024 14:22

Pull request was closed

@eustas eustas deleted the m420 branch December 23, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants