Allow to ask for memory with 0-side padding. #3648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sboukortt
previously approved these changes
Jun 17, 2024
Contributor
|
Could be simpler if we agree that pre_padding is always (A) |
szabadka
reviewed
Jun 18, 2024
In the render pipeline, we promise 16 floats before the pointer passed to each stage to be readable. Because of implementation details of the pre-memory-manager image allocation, that was always the case before. Once we started using the memory manager, this is no longer the case. This PR introduces the possibility to explicitly ask for such padding and uses it in the render pipeline.
szabadka
approved these changes
Jun 18, 2024
eustas
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the render pipeline, we promise 16 floats before the pointer passed to each stage to be readable.
Because of implementation details of the pre-memory-manager image allocation, that was always the case before. Once we started using the memory manager, this is no longer the case. This PR introduces the possibility to explicitly ask for such padding and uses it in the render pipeline.