Update search path for highway version #3644
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version 1.2.0 of highway the defines used to determine the version moved from `highway.h` to `base.h`. See if the version is in `base.h` and if not look in `highway.h`.
|
thanks! duplicate of #3642 |
|
Sorry didn't see that @mo271 ! If you want to steal anything from this feel free. Think the changes are a bit simpler in this one. |
|
closed in favour of #3642, but many thanks nonetheless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 1.2.0 of highway the defines used to determine the version moved from
highway.htobase.h. See if the version is inbase.hand if not look inhighway.h.Description
Modified the
FindHWY.cmakemodule to search for version numbers inbase.hthenhighway.h. The change in highway occurred at google/highway@1bf05d6Pull Request Checklist
./ci.sh lintfor automatic code formatting.Please review the full contributing guidelines for more details.