这是indexloc提供的服务，不要输入任何密码
Skip to content

KTOR-8583 Remove spaces from constant names #4933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

KTOR-8583 Remove spaces from constant names #4933

merged 1 commit into from
Jun 13, 2025

Conversation

osipxd
Copy link
Member

@osipxd osipxd commented Jun 13, 2025 •
edited
Loading

Subsystem
Android, R8

Motivation
KTOR-8583 "Space characters in SimpleName" error when executing R8 mergeExtDex task with 3.2.0

Solution
Even though these constants are inlined at compile time, D8 fails to transform the class.
Remove spaces from constant names.

@osipxd osipxd self-assigned this Jun 13, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 13, 2025 •
edited
Loading

Walkthrough

The update refactors the naming of private constant string properties within the Messages object in a Kotlin source file. It changes the constants from backtick-enclosed lowercase names to uppercase snake_case names, updates their references accordingly, and removes a suppression annotation. No public API or message content is altered.

Changes

File Path Change Summary
ktor-client/ktor-client-core/common/src/io/ktor/client/plugins/SaveBody.kt Renamed private constants in Messages to uppercase snake_case, updated references, removed annotation

Suggested reviewers

  • bjhham
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 086dc97 and 0c43625.

📒 Files selected for processing (1)
  • ktor-client/ktor-client-core/common/src/io/ktor/client/plugins/SaveBody.kt (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • ktor-client/ktor-client-core/common/src/io/ktor/client/plugins/SaveBody.kt
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@osipxd osipxd enabled auto-merge (squash) June 13, 2025 08:57
@osipxd osipxd disabled auto-merge June 13, 2025 09:14
@osipxd osipxd force-pushed the osipxd/fix-constant-names branch from 80bcd4d to 086dc97 Compare June 13, 2025 11:36
@osipxd osipxd force-pushed the osipxd/fix-constant-names branch from 086dc97 to 0c43625 Compare June 13, 2025 12:17
@osipxd osipxd enabled auto-merge (squash) June 13, 2025 13:45
@osipxd osipxd merged commit 03576de into main Jun 13, 2025
15 of 18 checks passed
@osipxd osipxd deleted the osipxd/fix-constant-names branch June 13, 2025 13:51
masterQian added a commit to rachel-ylcs/ylcs-kmp that referenced this pull request Jun 13, 2025
@masterQian
rollback: Ktor出现bug回滚版本
32d5703 
 ktorio/ktor#4933
svenjacobs added a commit to svenjacobs/lokksmith that referenced this pull request Jun 15, 2025
@svenjacobs
fix(deps): downgrade Ktor to 3.1.3 because of R8 issue (KTOR-8583)
0810762 
ktorio/ktor#4933
@svenjacobs svenjacobs mentioned this pull request Jun 15, 2025
Merged
svenjacobs added a commit to svenjacobs/lokksmith that referenced this pull request Jun 15, 2025
@svenjacobs
fix(deps): downgrade Ktor to 3.1.3 because of R8 issue (KTOR-8583) (#42)
a6d39f1 
ktorio/ktor#4933
@ArleyPereira
Copy link

In which version was this fixed? Upgrading from version 3.1.3 to version 3.2.0 and I get this same error.

@osipxd
Copy link
Member Author

osipxd commented Jun 17, 2025

In which version was this fixed? Upgrading from version 3.1.3 to version 3.2.0 and I get this same error.

This fix is going to be included in 3.2.1 which is scheduled for the next week

@zsmb13 zsmb13 mentioned this pull request Jun 18, 2025
Merged
@mslowik-mt mslowik-mt mentioned this pull request Jun 27, 2025
Closed
@vividcodex
Copy link

Has 3.2.1 been released?

@silveryTitan
Copy link

Hi! Has 3.2.1 been released?

@mattmapadmi
Copy link

Hi! Has 3.2.1 been released?

No https://github.com/ktorio/ktor/releases

@osipxd
Copy link
Member Author

osipxd commented Jun 30, 2025 •
edited
Loading

I'm sorry, I've posted an update on the release date in KTOR-8583, but forgot to update it here.
The release date has been updated. It is planned for this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjhham bjhham bjhham approved these changes

Assignees

@osipxd osipxd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@osipxd @ArleyPereira @vividcodex @silveryTitan @mattmapadmi @bjhham