这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@droot
Copy link
Contributor

@droot droot commented May 9, 2022

This adds namespace provisioning using UI guide.

@droot droot force-pushed the porch-ui-guides branch from ea2f10a to 28a4d21 Compare May 9, 2022 22:23
@@ -1,4 +1,4 @@
# Namespace provisioning example via kpt CLI
# Namespace provisioning using kpt CLI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to align the naming between CLI and UI (UI is marked as "example" while CLI is not)

- [The Rationale behind kpt](guides/rationale.md)
- [Namespace provisioning example](guides/namespace-provisioning-example.md)
- [Namespace provisioning CLI](guides/namespace-provisioning-cli.md)
- [Namespace provisioning UI](guides/namespace-provisioning-ui.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like removing the "example" could be confusing here:1. it seems to be the prerequisite to use Porch. 2. it's placed right after "Rationale" and before "Porch", which seems to be the second thing users should be consider (even before installing porch?)


In this guide, we will use the package orchestration UI to:

- Register blueprint and deployment repositories
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest addling the link to tell what "blueprint", "deployment" and "repository" means here. It seems to be the term related to "repository".


- Register blueprint and deployment repositories
- Create a `kpt` package from scratch in blueprint repo
- Create a deployable instance of the `kpt` package
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a doc to talk about "variant constructor"? It seems confusing especially for existing kpt users.

@yuwenma
Copy link
Contributor

yuwenma commented May 9, 2022

Approved since the comments are not blockers.

@droot
Copy link
Contributor Author

droot commented May 10, 2022

Thanks Yuwen for the feedback. I have taken notes and will address them in the follow up PRs.

@droot droot merged commit 329f948 into kptdev:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants