Refactor Dialog and DialogManager for improved key generation #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation of Dialog and DialogManager was refactored to improve key generation. Instead of using just chatId, it is now combined with userId to generate a unique key for a dialog. This solution further enhance balance between performance and security for reading and storing dialog states. Some unnecessary methods and properties were also cleaned up in the process.
Two new methods have been added to the Dialog class: "beforeAllStep" and "afterAllStep". These methods, which can be overridden for custom functionality, will run at the start and end of a Dialog sequence respectively. Additionally, a check has been implemented to determine when the Dialog has started.
The same line setting variable $currentStepIndex to $this->next was unnecessarily repeated in the script. This redundancy was removed to enhance code efficiency and improve readability.
Author
alies-dev
approved these changes
May 10, 2024
Collaborator
|
hey @CrazyBoy49z I found an opportunity to add this feature without introducing breaking changes. It's already released, but, unfortunately, it will not be compatible with your integration (at least during serialisation and unserialization). I hope it will not be a big issue for you to continue to use this package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4
The previous implementation of Dialog and DialogManager was refactored to improve key generation. Instead of using just chatId, it is now combined with userId to generate a unique key for a dialog. This solution further enhance balance between performance and security for reading and storing dialog states. Some unnecessary methods and properties were also cleaned up in the process.