Bugfix in proceedConfiguredStep function in dialog.php: json_encode of reply_markup added #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f reply_markup added
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #37 +/- ##
============================================
- Coverage 52.39% 51.82% -0.58%
- Complexity 90 92 +2
============================================
Files 8 8
Lines 271 274 +3
============================================
Hits 142 142
- Misses 129 132 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alies-dev
approved these changes
Nov 27, 2024
Collaborator
alies-dev
left a comment
There was a problem hiding this comment.
Thank you, @dimaodnokoz
Ideally, we need to add some tests for this functionality, I'll probably do it today later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think json_encode should be on the side of this package, because the code
$params['reply_markup'] = (string) $params['reply_markup'];
in vendor/irazasyed/telegram-bot-sdk/src/Traits/Http.php:137
works well for reply_markup, which is built according to their docs here
https://telegram-bot-sdk.com/docs/guides/keyboards
Update manually tested for:
'reply_markup' => [
'keyboard' => [
['q', '1'],
['2'],
],
'resize_keyboard' => true,
'is_persistent' => true,
],
//==============================
'reply_markup' => [
'keyboard' => [
[''],
],
'resize_keyboard' => true,
'is_persistent' => true,
],
//==============================
'reply_markup' => [
'keyboard' => [
[],
],
'resize_keyboard' => true,
'is_persistent' => true,
],
//==============================
'reply_markup' => [
'keyboard' => [],
'resize_keyboard' => true,
'is_persistent' => true,
],
//==============================
'reply_markup' => [
'resize_keyboard' => true,
'is_persistent' => true,
],
//==============================
'reply_markup' => [],