Enhance DialogManager::findDialogKeyForStore to make it more type-specific
#33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
============================================
+ Coverage 42.95% 43.15% +0.19%
Complexity 99 99
============================================
Files 9 9
Lines 291 292 +1
============================================
+ Hits 125 126 +1
Misses 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$update->getMessage()always returns Collection instance or child of this class, that makes code less predictable due to a lot of magic inside the Collection class. This PR focuses on improvingfindDialogKeyForStoreto make it more readable for developers and static analyzers.Please merge it after merging "Add more tests for all types of Updates (incl. json fixtures) #32" (as we firstly need to have a great test coverage for all possible Update types)