Switch (to another step) added, end() modified in Dialog. Tests added. #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…once. Added SwitchToAnotherStepException, which is thrown by switch function. Added catch of exception in DialogManager. Added switch to proceedConfiguredStep in Dialog and in advanced-dialogs.md. Added tests for all that: modified PassiveTestDialog to test switch and switch-in-ConfiguredSteps in DialogManagerTest.php, moved test of afterLastStep-after-jump from DialogMangerTest.php to DialogTest.php
…n last step and in some other step: step complpeted, all after step completed (afterEveryStep for any step, + afterLastStep for last step), dialog forgotten. Added test in DialogTest.php for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch for Dialog
switchmethod to switch to new step and proceed at onceSwitchToAnotherStepException, which is thrown byswitchmethod-- modified PassiveTestDialog to test switch and switch-in-ConfiguredSteps in DialogManagerTest.php
-- moved test of afterLastStep-after-jump from DialogMangerTest.php to DialogTest.php
End function for Dialog
--step complpeted
-- all after step completed (afterEveryStep for any step, + afterLastStep for last step)
-- dialog forgotten