Use Laravel Cache and PSR-16 (Remove custom Store interface and implementations) #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove custom implementations of Store and use PSR-16 implementations (e.g. Provided by Laravel).
Note, from v0.9 the package already supports PSR-16 implementations. This PR removes Store interface and Redis implementations and updates Laravel Service Provider to inject new dependencies. Ideally it can be a release with a low chance of BC breaks (only for cases when developers used Store, RedisStore and RedisStoreAdapter classes directly [what is not recommended]).
Also, all package docs already updated to use PSR-16: