Propagate Ingress status to DomainMapping #9752
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9752 +/- ##
==========================================
- Coverage 87.77% 87.77% -0.01%
==========================================
Files 180 180
Lines 8499 8521 +22
==========================================
+ Hits 7460 7479 +19
- Misses 792 793 +1
- Partials 247 249 +2
Continue to review full report at Codecov.
|
| if ingress.GetObjectMeta().GetGeneration() != ingress.Status.ObservedGeneration { | ||
| dm.Status.MarkIngressNotConfigured() |
There was a problem hiding this comment.
I'd add a comment that it's ingress we're looking at, since it took me a moment to see that it's different object from above 😊
There was a problem hiding this comment.
this is copied from https://github.com/knative/serving/blob/master/pkg/reconciler/route/route.go#L161 which also doesn't have comment, but sure I'll add one
|
Needs a rebase :( |
b10192f to
922a494
Compare
|
rebased. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Third part of #9713.
This gets things working end-to-end (without domain claims, validation, ability to set ingress class etc etc of course), so should be able to land the initial conformance test after this.
/assign @mattmoor @dprotaso