Update autoscaler CM example block for max-scale-limit #9577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julz
reviewed
Sep 25, 2020
Comment on lines
191
to
194
| # max-scale-limit ensures that both cluster-wide flag max-scale and per-revision | ||
| # annotation "autoscaling.knative.dev/maxScale" for new revision will not exceed | ||
| # this number. If max-scale-limit is greater than 0, it disables both explicitly | ||
| # setting "autoscaling.knative.dev/maxScale" annotation to 0 and leaving it unset. |
There was a problem hiding this comment.
I feel like the fact that this affects both the annotation and the config might be implicit. How about:
Suggested change
| # max-scale-limit ensures that both cluster-wide flag max-scale and per-revision | |
| # annotation "autoscaling.knative.dev/maxScale" for new revision will not exceed | |
| # this number. If max-scale-limit is greater than 0, it disables both explicitly | |
| # setting "autoscaling.knative.dev/maxScale" annotation to 0 and leaving it unset. | |
| # max-scale-limit sets the maximum permitted value for the max scale of a revision. | |
| # When this is set to a positive value, a revision with a maxScale above that value | |
| # (including a maxScale of "0" = unlimited) is disallowed. | |
| # A value of zero (the default) allows any limit, including unlimited. |
julz
reviewed
Sep 25, 2020
vagababov
reviewed
Sep 25, 2020
|
Oh yeah good point /hold for release |
bca6931 to
f9e34f6
Compare
Codecov Report
@@ Coverage Diff @@
## master #9577 +/- ##
==========================================
+ Coverage 88.35% 88.38% +0.02%
==========================================
Files 193 193
Lines 8632 8632
==========================================
+ Hits 7627 7629 +2
+ Misses 761 760 -1
+ Partials 244 243 -1
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: taragu, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8628
/hold for #9496
Proposed Changes
Update autoscaler CM example block for max-scale-limit
Release Note
/assign @markusthoemmes @vagababov @julz