这是indexloc提供的服务，不要输入任何密码
Skip to content

Finish the testing of the queue proxy handler #9566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2020
Merged

Finish the testing of the queue proxy handler #9566

merged 3 commits into from
Sep 25, 2020

Conversation

vagababov
Copy link
Contributor

Added tests to cover:

  • client side timeout
  • queue overflow
  • coverage or serving without breaker (cc=0)

/assign @yanweiguo mattmoor

@vagababov
Finish the testing of the queue proxy handler
7230908 
Added tests to cover:
- client side timeout
- queue overflow
- coverage or serving without breaker (cc=0)

Change-Id: I3a13f022abd06ec53c774c7c8d8209285ba266cb
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 24, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 24, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale area/networking labels Sep 24, 2020
@vagababov
avoid race
e88c229 
Change-Id: I13c8ef4ea9c6deaed28f03c4ac9a29dac7c570a5
@vagababov
rename
a24b605 
Change-Id: Ie82a8ef2d3855a501a85b8014affc77f851ea7a1
@codecov
Copy link

codecov bot commented Sep 24, 2020 •
edited
Loading

Codecov Report

Merging #9566 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9566      +/-   ##
==========================================
+ Coverage   88.70%   88.78%   +0.07%     
==========================================
  Files         213      213              
  Lines        9387     9387              
==========================================
+ Hits         8327     8334       +7     
+ Misses        802      796       -6     
+ Partials      258      257       -1
Impacted Files Coverage Δ
pkg/queue/handler.go 93.75% <ø> (+21.87%) ⬆️
pkg/reconciler/autoscaling/kpa/scaler.go 88.40% <0.00%> (-1.45%) ⬇️
pkg/reconciler/configuration/configuration.go 89.16% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3432804...a24b605. Read the comment docs.

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/queue/handler.go 81.5% 96.3% 14.8

@vagababov
Copy link
Contributor Author

Should be good now.

@mattmoor
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2020
@knative-prow-robot knative-prow-robot merged commit 8221279 into knative:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JRBANCEL JRBANCEL Awaiting requested review from JRBANCEL

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@mattmoor mattmoor

@yanweiguo yanweiguo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vagababov @knative-prow-robot @knative-metrics-robot @mattmoor @googlebot @yanweiguo