Add new ConfigMap field for max-max-scale #9419
Conversation
There was a problem hiding this comment.
@taragu: 0 warnings.
In response to this:
/lint
Part of #8628
Proposed Changes
Add new ConfigMap field for max-max-scale
/assign @vagababov @markusthoemmes @julz
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
| @@ -150,6 +154,7 @@ func NewConfigFromMap(data map[string]string) (*Config, error) { | |||
|
|
|||
| cm.AsInt32("initial-scale", &lc.InitialScale), | |||
| cm.AsInt32("max-scale", &lc.MaxScale), | |||
| cm.AsInt32("max-max-scale", &lc.MaxMaxScale), | |||
There was a problem hiding this comment.
I'm not sure whether we can have a better name :)
| @@ -150,6 +154,7 @@ func NewConfigFromMap(data map[string]string) (*Config, error) { | |||
|
|
|||
| cm.AsInt32("initial-scale", &lc.InitialScale), | |||
| cm.AsInt32("max-scale", &lc.MaxScale), | |||
| cm.AsInt32("max-max-scale", &lc.MaxMaxScale), | |||
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: taragu, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LOL I think "maxestScale" would have been too funny! |
|
@julz |
/lint
Part of #8628
Proposed Changes
Add new ConfigMap field for max-max-scale
/assign @vagababov @markusthoemmes @julz