这是indexloc提供的服务,不要输入任何密码
Skip to content

[release-1.1] Move liveness checks to user container port rather than QP port #12498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #12479

Changes liveness probes to directly probe the user container rather than queue proxy.

Otherwise these get intercepted by the drainer logic in queue proxy, which is
not what we want.

Initially liveness and readiness were routed via the queue proxy so that a
single check could check both user container and queue proxy; while this makes
some sense for Readiness (because we need this for optimisations in activator
that need to check readiness of the whole pod at once), for liveness this is
both not needed and actively harmful. A failing liveness probe results in
Kubernetes restarting the failing container (in this case, the user container),
but if the failure comes from QP this will not help (and is actively
unhelpful).  TL;dr: If we want to add a liveness probe to Queue Proxy, we should
add that directly rather than modifying the user's probe to go via the Queue
Proxy port.
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/API API objects and controllers labels Jan 12, 2022
@dprotaso
Copy link
Member

/assign @julz @psschwei @nader-ziada

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #12498 (8524fbe) into release-1.1 (7499ae2) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.1   #12498      +/-   ##
===============================================
- Coverage        87.39%   87.37%   -0.03%     
===============================================
  Files              195      195              
  Lines             9646     9646              
===============================================
- Hits              8430     8428       -2     
- Misses             931      933       +2     
  Partials           285      285              
Impacted Files Coverage Δ
pkg/reconciler/revision/resources/deploy.go 96.87% <100.00%> (ø)
pkg/autoscaler/scaling/multiscaler.go 87.27% <0.00%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7499ae2...8524fbe. Read the comment docs.

Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2022
@dprotaso
Copy link
Member

/approve

@knative-prow-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2022
@knative-prow-robot knative-prow-robot merged commit cee54d5 into knative:release-1.1 Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants