-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fixes an activator panic when the throttle encounters a cache.DeleteFinalStateUnknown #12679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/cherry-pick release-1.2 |
@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
flaky - #12490 /retest |
Codecov Report
@@ Coverage Diff @@
## main #12679 +/- ##
==========================================
+ Coverage 87.27% 87.31% +0.04%
==========================================
Files 196 196
Lines 9736 9739 +3
==========================================
+ Hits 8497 8504 +7
+ Misses 952 950 -2
+ Partials 287 285 -2
Continue to review full report at Codecov.
|
/retest |
/lgtm |
@dprotaso: new pull request created: #12680 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #12676
Note: I couldn't figure out a way to reproduce this with the client-go fakes
Release Note