Updates val webhook selector to reduce invocations #12612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we install networking with serving, multiple validating webhooks are registered. Previously, the webhooks were configured with just namespace selectors that are identical. Thus when the config file is updated, the serving webhook is invoked (which is a noop) and vice-versa for any serving config maps. To avoid this, this PR updates the validating webhook to use an objectSelector and includes an extra label (app.kubernetes.io/component) to further distinguish net-istio resources from serving resources. It also adds component labels to several of the configmaps that did not have them.
|
Depends on: #12624 |
|
/hold cancel |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we install networking with serving, multiple validating
webhooks are registered.
Previously, the webhooks were configured with just namespace
selectors that are identical. Thus when the config file is updated,
the serving webhook is invoked (which is a noop) and vice-versa
for any serving config maps.
To avoid this, this PR updates the validating webhook to use an
objectSelector and includes an extra label (app.kubernetes.io/component)
to further distinguish net-istio resources from serving resources.
It also adds component labels to several of the configmaps that did
not have them.
Fixes #12594
Release Note
Needs the changes in knative/networking#616 to merge and update dependencies here to work
/hold