这是indexloc提供的服务，不要输入任何密码
Skip to content

Bump cert-manager to 1.7.1 #12605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 9, 2022
Merged

Bump cert-manager to 1.7.1 #12605

merged 3 commits into from
Feb 9, 2022

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Feb 9, 2022

Release Note

net-certmanager starts testing cert-manager v1.7.1.

@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 9, 2022
ZhiminXiang
ZhiminXiang approved these changes Feb 9, 2022
View reviewed changes
Copy link

@ZhiminXiang ZhiminXiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2022
@codecov
Copy link

codecov bot commented Feb 9, 2022 •
edited
Loading

Codecov Report

Merging #12605 (64f73b7) into main (52f07b0) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12605      +/-   ##
==========================================
+ Coverage   87.48%   87.52%   +0.04%     
==========================================
  Files         195      195              
  Lines        9718     9718              
==========================================
+ Hits         8502     8506       +4     
+ Misses        931      928       -3     
+ Partials      285      284       -1
Impacted Files Coverage Δ
pkg/reconciler/revision/background.go 91.81% <0.00%> (+1.81%) ⬆️
pkg/autoscaler/statserver/server.go 79.61% <0.00%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52f07b0...64f73b7. Read the comment docs.

@nak3 nak3 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2022
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2022
@nak3
Copy link
Contributor Author

nak3 commented Feb 9, 2022

/test pull-knative-serving-upgrade-tests

unrelated failure.

@nak3 nak3 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2022
@nak3
Copy link
Contributor Author

nak3 commented Feb 9, 2022

/test pull-knative-serving-upgrade-tests

Hmm 🤔 Upgrade-test does not use net-certmanager so the failure should not be related.

@dprotaso
Copy link
Member

dprotaso commented Feb 9, 2022

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, nak3, ZhiminXiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2022
@knative-prow-robot knative-prow-robot merged commit 6c0fdec into knative:main Feb 9, 2022
@nak3 nak3 deleted the bump-certmanager branch February 10, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhiminXiang ZhiminXiang ZhiminXiang approved these changes

Assignees

@dprotaso dprotaso

@ZhiminXiang ZhiminXiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nak3 @dprotaso @knative-prow-robot @ZhiminXiang