Drop now-unneeded unix socket from queue proxy #12298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unix socket listener was added so that the exec probe could avoid doing the whole tcp networking stack dance when it was spawned every second, but we no longer use an exec probe in Queue Proxy so nothing is contacting the socket any more.
Codecov Report
@@ Coverage Diff @@
## main #12298 +/- ##
==========================================
+ Coverage 87.33% 87.45% +0.11%
==========================================
Files 195 195
Lines 9610 9595 -15
==========================================
- Hits 8393 8391 -2
+ Misses 938 924 -14
- Partials 279 280 +1
Continue to review full report at Codecov.
|
|
looks like prow agrees \o/ |
|
/assign @psschwei @nader-ziada |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unix socket listener was added so that the exec probe could avoid
doing the whole tcp networking stack dance when it was spawned every
second, but we no longer use an exec probe in Queue Proxy so nothing is
contacting the socket any more.
WIP: let's see if prow agreesRelease Note