这是indexloc提供的服务，不要输入任何密码
Skip to content

Drop redundant queue-proxy startup probe #11965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2021
Merged

Drop redundant queue-proxy startup probe #11965

merged 3 commits into from
Sep 13, 2021

Conversation

markusthoemmes
Copy link
Contributor

@markusthoemmes markusthoemmes commented Sep 9, 2021 •
edited
Loading

Fixes #11956

Proposed Changes

The linked issue has all the necessary data and arguing. Current nightly build data

Created 100 basic pods sequentially, results are in ms:

metric            |min  |max  |mean |p95  |p99
Time to scheduled |20   |96   |34   |53   |66
Time to ip        |1414 |2889 |2123 |2451 |2877
Time to ready     |1793 |4362 |3193 |3825 |4076

Data of this PR

Created 100 basic pods sequentially, results are in ms:

metric            |min  |max  |mean |p95  |p99
Time to scheduled |13   |64   |24   |34   |57
Time to ip        |1263 |2314 |1944 |2279 |2286
Time to ready     |1338 |3277 |2463 |3046 |3229

/hold

For data to come in.

Release Note

Dropped the startup probe on the queue-proxy which makes the pods start ~500ms quicker on average.

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/API API objects and controllers approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 9, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021 •
edited
Loading

Codecov Report

Merging #11965 (b3305c8) into main (cc19d71) will decrease coverage by 0.02%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11965      +/-   ##
==========================================
- Coverage   87.64%   87.62%   -0.03%     
==========================================
  Files         197      196       -1     
  Lines        9521     9473      -48     
==========================================
- Hits         8345     8301      -44     
+ Misses        909      905       -4     
  Partials      267      267
Impacted Files Coverage Δ
cmd/queue/main.go 0.50% <0.00%> (+<0.01%) ⬆️
pkg/reconciler/revision/resources/queue.go 98.09% <ø> (-0.14%) ⬇️
pkg/queue/health/probe.go 52.63% <33.33%> (-0.62%) ⬇️
pkg/reconciler/revision/background.go 91.26% <0.00%> (-0.41%) ⬇️
pkg/reconciler/revision/revision.go 88.05% <0.00%> (+0.18%) ⬆️
pkg/activator/net/revision_backends.go 92.41% <0.00%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc19d71...b3305c8. Read the comment docs.

@knative-prow-robot knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Sep 9, 2021
@markusthoemmes
Copy link
Contributor Author

/retest

julz
julz reviewed Sep 10, 2021
View reviewed changes
Copy link
Member

@julz julz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given this will (I think) make the exec probe unused, do we want to delete those files at the same time?

@markusthoemmes
Copy link
Contributor Author

@julz I think we should at least keep some version of it for a release to avoid weird effects when updating Knative (remember when we renamed the flag to call into the binary?)

@julz
Copy link
Member

julz commented Sep 10, 2021

interesting yeah, it feels like it should be impossible since we could only roll the new image on a reconcile where we'd also remove the probe but.. you're very likely right, it's possible for the configmap change with the QP image to roll through before the code is updated. Should we add a todo comment to the files or an issue to remember to clean them up next release then?

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/autoscale area/networking and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 10, 2021
julz
julz approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@julz julz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a very pleasant amount of red (though will be happy to see some of it reintroduced if/when we fix upstream k8s to make the optimisation work)

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: julz, markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markusthoemmes
Copy link
Contributor Author

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2021
@knative-prow-robot knative-prow-robot merged commit 2990cf0 into knative:main Sep 13, 2021
@julz julz mentioned this pull request Nov 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julz julz julz approved these changes

Assignees

@julz julz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider dropping the exec probe "optimization" for now
3 participants
@markusthoemmes @julz @knative-prow-robot