这是indexloc提供的服务,不要输入任何密码
Skip to content

Change magic DNS to sslip.io #11298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2021
Merged

Change magic DNS to sslip.io #11298

merged 1 commit into from
May 4, 2021

Conversation

julz
Copy link
Member

@julz julz commented May 4, 2021

Fixes #11297.

As the issue says, looks like xip.io has been shut down for several days (possibly related to https://twitter.com/sstephenson/status/1388146131377528832) so the docs are currently broken.

(We could alternatively use nip.io, I don't feel strongly about the alternative we use, I just picked one).

Release Note

Change the default post-install job to use sslip.io rather than xip.io.

/assign @dprotaso @evankanderson

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label May 4, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 4, 2021
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #11298 (6da91ef) into main (c2f3fda) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11298      +/-   ##
==========================================
- Coverage   87.75%   87.69%   -0.07%     
==========================================
  Files         191      191              
  Lines        9205     9205              
==========================================
- Hits         8078     8072       -6     
- Misses        875      880       +5     
- Partials      252      253       +1     
Impacted Files Coverage Δ
pkg/autoscaler/scaling/multiscaler.go 87.61% <0.00%> (-1.77%) ⬇️
pkg/autoscaler/statforwarder/leases.go 76.97% <0.00%> (-1.44%) ⬇️
pkg/activator/net/revision_backends.go 91.51% <0.00%> (-0.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2f3fda...6da91ef. Read the comment docs.

@julz
Copy link
Member Author

julz commented May 4, 2021

We might also want to cherry pick this on to at least the previous release so that the docs for the latest release work.

Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cherrypick release-0.22
/cherrypick release-0.21
/cherrypick release-0.20
/cherrypick release-0.19

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2021
@knative-prow-robot knative-prow-robot merged commit ad94366 into main May 4, 2021
@dprotaso dprotaso deleted the unxip branch May 5, 2021 03:17
@dprotaso
Copy link
Member

dprotaso commented May 5, 2021

weird the cherry picks didn't work

/cherrypick release-0.22
/cherrypick release-0.21
/cherrypick release-0.20
/cherrypick release-0.19

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #11299

In response to this:

weird the cherry picks didn't work

/cherrypick release-0.22
/cherrypick release-0.21
/cherrypick release-0.20
/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nak3
Copy link
Contributor

nak3 commented May 14, 2021

/cherrypick release-0.21

@knative-prow-robot
Copy link
Contributor

@nak3: new pull request created: #11345

In response to this:

/cherrypick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nak3
Copy link
Contributor

nak3 commented May 14, 2021

/cherrypick release-0.20

@nak3
Copy link
Contributor

nak3 commented May 14, 2021

/cherrypick release-0.19

@knative-prow-robot
Copy link
Contributor

@nak3: new pull request created: #11346

In response to this:

/cherrypick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

@nak3: new pull request created: #11347

In response to this:

/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xip.io Magic DNS stopped working
5 participants