-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Change magic DNS to sslip.io #11298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change magic DNS to sslip.io #11298
Conversation
Codecov Report
@@ Coverage Diff @@
## main #11298 +/- ##
==========================================
- Coverage 87.75% 87.69% -0.07%
==========================================
Files 191 191
Lines 9205 9205
==========================================
- Hits 8078 8072 -6
- Misses 875 880 +5
- Partials 252 253 +1
Continue to review full report at Codecov.
|
We might also want to cherry pick this on to at least the previous release so that the docs for the latest release work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cherrypick release-0.22
/cherrypick release-0.21
/cherrypick release-0.20
/cherrypick release-0.19
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
weird the cherry picks didn't work /cherrypick release-0.22 |
@dprotaso: new pull request created: #11299 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-0.21 |
@nak3: new pull request created: #11345 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-0.20 |
/cherrypick release-0.19 |
@nak3: new pull request created: #11346 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@nak3: new pull request created: #11347 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #11297.
As the issue says, looks like xip.io has been shut down for several days (possibly related to https://twitter.com/sstephenson/status/1388146131377528832) so the docs are currently broken.
(We could alternatively use nip.io, I don't feel strongly about the alternative we use, I just picked one).
Release Note
/assign @dprotaso @evankanderson