Validate default max scale is set if max scale limit is enabled #10921
Conversation
If a non zero scale limit is set and no default is provided the "out of the box" situation for ksvcs is invalid. The operator should provide a reasonable non-infinite default for users if a limit is set.
pkg/autoscaler/config/config.go
Outdated
| } | ||
|
|
||
| if lc.MaxScale < minMaxScale || (lc.MaxScaleLimit > 0 && lc.MaxScale > lc.MaxScaleLimit) { | ||
| return nil, fmt.Errorf("max-scale = %d, must be in [%d, max-scale-limit] range", minMaxScale, lc.MaxScale) |
There was a problem hiding this comment.
I think the args are in reverse order here.
Codecov Report
@@ Coverage Diff @@
## main #10921 +/- ##
==========================================
- Coverage 88.04% 88.02% -0.02%
==========================================
Files 188 188
Lines 9100 9103 +3
==========================================
+ Hits 8012 8013 +1
- Misses 833 834 +1
- Partials 255 256 +1
Continue to review full report at Codecov.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-knative-serving-istio-stable-no-mesh |
If a non zero max scale limit is set and no default max scale is provided the "out of the box" situation for ksvcs is invalid (a default ksvc without annotations will fail validation). The operator should provide a reasonable - non-infinite - default for users if a limit is set.
See #10825, #10847.
/assign @dprotaso @markusthoemmes