这是indexloc提供的服务，不要输入任何密码
Skip to content

add feature flag for hostAliases #10301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2020
Merged

add feature flag for hostAliases #10301

merged 1 commit into from
Dec 15, 2020

Conversation

emaildanwilson
Copy link
Contributor

@emaildanwilson emaildanwilson commented Dec 7, 2020 •
edited
Loading

Fixes #9415

Proposed Changes

  • Adds a flag kubernetes.podspec-hostaliases in config-features with a default of disabled
  • Adds unit tests for this feature flag

Release Note

A feature flag is now available to enable hostAliases for Knative Services. See config-features for details.

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 7, 2020
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 7, 2020
@knative-prow-robot
Copy link
Contributor

Hi @emaildanwilson. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added area/API API objects and controllers needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/networking labels Dec 7, 2020
@yanweiguo
Copy link
Contributor

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 7, 2020
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #10301 (9143de0) into master (66e2c51) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10301      +/-   ##
==========================================
+ Coverage   88.21%   88.24%   +0.02%     
==========================================
  Files         184      184              
  Lines        8649     8652       +3     
==========================================
+ Hits         7630     7635       +5     
  Misses        784      784              
+ Partials      235      233       -2
Impacted Files Coverage Δ
pkg/apis/config/features.go 93.75% <100.00%> (+0.41%) ⬆️
pkg/apis/serving/fieldmask.go 95.48% <100.00%> (+0.01%) ⬆️
pkg/activator/net/revision_backends.go 90.49% <0.00%> (-0.91%) ⬇️
pkg/autoscaler/statforwarder/forwarder.go 82.44% <0.00%> (+1.06%) ⬆️
pkg/reconciler/configuration/configuration.go 88.28% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66e2c51...e9b17e3. Read the comment docs.

mattmoor
mattmoor approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Can you please add this to: https://github.com/knative/docs/blob/2c34cb0a866fce4907b7a88f41ad5f4423e52ff6/docs/serving/feature-flags.md?

HOLD is to make sure you see ☝️

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2020
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: emaildanwilson, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2020
@emaildanwilson emaildanwilson mentioned this pull request Dec 9, 2020
Merged
@emaildanwilson
Copy link
Contributor Author

Thank you! The docs PR is opened now.

@mattmoor
Copy link
Member

mattmoor commented Dec 9, 2020

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2020
@emaildanwilson
Copy link
Contributor Author

/assign @ZhiminXiang @yanweiguo

@emaildanwilson
Copy link
Contributor Author

/retest

1 similar comment
@markusthoemmes
Copy link
Contributor

/retest

@markusthoemmes
Copy link
Contributor

/test pull-knative-serving-istio-stable-no-mesh

@knative-prow-robot knative-prow-robot merged commit e30a309 into knative:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor approved these changes

@yanweiguo yanweiguo Awaiting requested review from yanweiguo

@ZhiminXiang ZhiminXiang Awaiting requested review from ZhiminXiang

Assignees

@mattmoor mattmoor

@ZhiminXiang ZhiminXiang

@yanweiguo yanweiguo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Allow specifying hostAliases for Knative Services
6 participants
@emaildanwilson @knative-prow-robot @yanweiguo @mattmoor @markusthoemmes @ZhiminXiang