Prevent DomainMapping collisions using ClusterDomainClaim #10044
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10044 +/- ##
==========================================
+ Coverage 87.94% 87.96% +0.02%
==========================================
Files 184 185 +1
Lines 8666 8683 +17
==========================================
+ Hits 7621 7638 +17
+ Misses 797 796 -1
- Partials 248 249 +1
Continue to review full report at Codecov.
|
| if dc, err = r.netclient.NetworkingV1alpha1().ClusterDomainClaims().Create(ctx, &netv1alpha1.ClusterDomainClaim{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: dm.Name, | ||
| OwnerReferences: []metav1.OwnerReference{*kmeta.NewControllerRef(dm)}, | ||
| }, | ||
| }, metav1.CreateOptions{}); err != nil { |
There was a problem hiding this comment.
I'd move to resources/ and use that in the table test, it should cut down on boilerplate.
|
Just a nit |
|
Consider an e2e test to confirm that two DomainMappings created in separate serving namespaces work. We have What's in my head:
|
|
e2e test sounds legit (I did test manually :)), I'll do that in a follow-on, if that's ok |
|
Yeah, that's fine, just wanted to put it on your list 😉 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Part of #9713.
Use the new ClusterDomainClaim CRD to prevent domain name collisions. At this point, we auto-create the CDC as part of reconciling the DM.
/assign @mattmoor @vagababov