Relax validation to allow Ref to be things other than Ksvc #10210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As well as removing the validation, this required changing the validation in the reconciler to permit '/' as the Path, since it turns out the addressable resolver adds this for services.
Codecov Report
@@ Coverage Diff @@
## master #10210 +/- ##
==========================================
+ Coverage 88.10% 88.18% +0.08%
==========================================
Files 184 184
Lines 8615 8606 -9
==========================================
- Hits 7590 7589 -1
+ Misses 789 784 -5
+ Partials 236 233 -3
Continue to review full report at Codecov.
|
|
/hold For the actual reviewers :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, markusthoemmes, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nak3
pushed a commit
to nak3/serving
that referenced
this pull request
Jan 21, 2021
…0210) As well as removing the validation, this required changing the validation in the reconciler to permit '/' as the Path, since it turns out the addressable resolver adds this for services.
nak3
pushed a commit
to nak3/serving
that referenced
this pull request
Jan 21, 2021
…0210) As well as removing the validation, this required changing the validation in the reconciler to permit '/' as the Path, since it turns out the addressable resolver adds this for services.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something something #9713.
Relaxes the validation since we now support DomainMapping targets that aren't KSvcs.
As well as relaxing the api type validation, this also relaxes the validation in the reconciler to permit a single '/' for the Path, since it turns out the addressable resolver returns this for services.
Release Note
/assign @mattmoor @vagababov