这是indexloc提供的服务，不要输入任何密码
Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

Default KafkaSource sink ref namespace to object namespace #943

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Default KafkaSource sink ref namespace to object namespace #943

merged 1 commit into from
Oct 19, 2021

Conversation

pierDipi
Copy link
Member

Sink namespace is not defaulted to the object namespace for:

  • KafkaSource

Forcing every implementation to define the logic:

"If spec.sink.ref.namespace is empty, use metadata.namespace"

Similar to knative/eventing#5748

Proposed Changes

  • Default KafkaSource sink namespace to object namespace

Release Note

The field `spec.sink.ref.namespace` for `KafkaSource` if not specified is defaulted to `metadata.namespace`.

Docs

None

/cc @aliok @matzew @lionelvillard

@pierDipi
Default KafkaSource sink namespace to object namespace
285a00f 
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 19, 2021
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 19, 2021 •
edited
Loading

Codecov Report

Merging #943 (285a00f) into main (ebe7bfb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #943   +/-   ##
=======================================
  Coverage   75.63%   75.64%           
=======================================
  Files         137      137           
  Lines        6543     6545    +2     
=======================================
+ Hits         4949     4951    +2     
  Misses       1311     1311           
  Partials      283      283
Impacted Files Coverage Δ
pkg/apis/sources/v1beta1/kafka_defaults.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe7bfb...285a00f. Read the comment docs.

@aliok
Copy link
Member

aliok commented Oct 19, 2021

/test pull-knative-sandbox-eventing-kafka-integration-test-channel-consolidated-tls

Infra

aliok
aliok approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 19, 2021
@pierDipi
Copy link
Member Author

/retest

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Oct 19, 2021 •
edited
Loading

@pierDipi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-knative-sandbox-eventing-kafka-go-coverage 285a00f link false /test pull-knative-sandbox-eventing-kafka-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-prow-robot knative-prow-robot merged commit 8b3f08b into knative-extensions:main Oct 19, 2021
@pierDipi pierDipi deleted the KNATIVE-312_Set-namespace-to-object-namespace branch October 19, 2021 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aliok aliok aliok approved these changes

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@matzew matzew Awaiting requested review from matzew

Assignees

@aliok aliok

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierDipi @aliok @knative-prow-robot