这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

control maximum allowed vreplica count #822

Merged

Conversation

steven0711dong
Copy link
Contributor

@steven0711dong steven0711dong commented Aug 24, 2021

Fixes #

Proposed Changes

Release Note

🎁 [Multi-tenant KafkaSource] Calculate an optimal maximum allowed vreplica number based on Kafka source partitions count so that scheduler does not schedule more vreplicas than the calculated number 

Docs

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steven0711dong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 24, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 24, 2021
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #822 (30c705c) into main (0a8228a) will decrease coverage by 0.15%.
The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #822      +/-   ##
==========================================
- Coverage   75.30%   75.14%   -0.16%     
==========================================
  Files         139      139              
  Lines        6439     6442       +3     
==========================================
- Hits         4849     4841       -8     
- Misses       1362     1369       +7     
- Partials      228      232       +4     
Impacted Files Coverage Δ
pkg/apis/sources/v1beta1/kafka_scheduling.go 75.00% <0.00%> (-25.00%) ⬇️
pkg/source/reconciler/source/kafkasource.go 0.00% <0.00%> (ø)
pkg/source/client/offsets.go 57.89% <33.33%> (+2.33%) ⬆️
test/rekt/resources/kafkachannel/kafkachannel.go 23.52% <0.00%> (-3.14%) ⬇️
...annel/distributed/controller/kafkachannel/topic.go 78.94% <0.00%> (-3.00%) ⬇️
pkg/channel/consolidated/utils/util.go 95.45% <0.00%> (-0.47%) ⬇️
...consolidated/reconciler/controller/kafkachannel.go 49.67% <0.00%> (-0.33%) ⬇️
pkg/common/kafka/sarama/sarama.go 94.91% <0.00%> (-0.09%) ⬇️
pkg/common/config/util.go 100.00% <0.00%> (ø)
pkg/apis/messaging/v1beta1/kafka_channel_types.go 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a8228a...30c705c. Read the comment docs.

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 24, 2021
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 26, 2021
@lionelvillard
Copy link
Contributor

/test pull-knative-sandbox-eventing-kafka-integration-test-channel-distributed

@steven0711dong can you fix the lint errors?

@steven0711dong
Copy link
Contributor Author

/retest

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/sources/v1beta1/kafka_scheduling.go 100.0% 80.0% -20.0
pkg/source/client/offsets.go 79.5% 80.5% 1.0

@lionelvillard
Copy link
Contributor

let's give it a try
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2021
@knative-prow-robot knative-prow-robot merged commit 24ac96b into knative-extensions:main Aug 27, 2021
@lionelvillard
Copy link
Contributor

/cherry-pick release-0.25

@knative-prow-robot
Copy link
Contributor

@lionelvillard: new pull request created: #860

In response to this:

/cherry-pick release-0.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants