这是indexloc提供的服务，不要输入任何密码
Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

removing confusing error message #809

Merged
merged 1 commit into from
Aug 18, 2021
Merged

removing confusing error message #809

merged 1 commit into from
Aug 18, 2021

Conversation

steven0711dong
Copy link
Contributor

@steven0711dong steven0711dong commented Aug 18, 2021 •
edited
Loading

Fixes #810

Proposed Changes

Release Note

🐛 Remove confusing error message `Kafka source is not ready`. This error is returned as an event regardless the Kafka source has any real issue or not and users should not see this error message unless it is a legitimate error or it is an error they can fix.

Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 18, 2021
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 18, 2021
lionelvillard
lionelvillard reviewed Aug 18, 2021
View reviewed changes
lionelvillard
lionelvillard reviewed Aug 18, 2021
View reviewed changes
@steven0711dong steven0711dong force-pushed the remove-confusing-error-msg branch from 54c2c10 to ae23c80 Compare August 18, 2021 14:17
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2021
@codecov
Copy link

codecov bot commented Aug 18, 2021 •
edited
Loading

Codecov Report

Merging #809 (ae23c80) into main (fdf11c5) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #809      +/-   ##
==========================================
- Coverage   75.22%   75.18%   -0.04%     
==========================================
  Files         139      139              
  Lines        6377     6380       +3     
==========================================
  Hits         4797     4797              
- Misses       1354     1357       +3     
  Partials      226      226
Impacted Files Coverage Δ
pkg/source/mtadapter/controller.go 0.00% <0.00%> (ø)
pkg/source/mtadapter/kafkasource.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdf11c5...ae23c80. Read the comment docs.

@lionelvillard
Copy link
Contributor

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, steven0711dong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 9ecd1fe into knative-extensions:main Aug 18, 2021
@lionelvillard
Copy link
Contributor

/cherry-pick release-0.24

@knative-prow-robot knative-prow-robot mentioned this pull request Aug 20, 2021
Merged
@knative-prow-robot
Copy link
Contributor

@lionelvillard: new pull request created: #816

In response to this:

/cherry-pick release-0.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lionelvillard lionelvillard lionelvillard left review comments

Assignees

@lionelvillard lionelvillard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove confusing error message
3 participants
@steven0711dong @lionelvillard @knative-prow-robot