这是indexloc提供的服务，不要输入任何密码
Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

[release-0.24] [Consolidated KafkaChannel] Set KafkaChannel consolidated dispatcher OwenrRef #802

Merged
merged 8 commits into from
Aug 11, 2021
Merged

[release-0.24] [Consolidated KafkaChannel] Set KafkaChannel consolidated dispatcher OwenrRef #802

merged 8 commits into from
Aug 11, 2021

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #798

- 🧽 The consolidated KafkaChannel dispatcher is now owned by the controller.

@knative-prow-robot knative-prow-robot mentioned this pull request Aug 11, 2021
Merged
@knative-prow-robot knative-prow-robot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 11, 2021
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 11, 2021
@google-cla
Copy link

google-cla bot commented Aug 11, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Aug 11, 2021
@devguyio
Copy link
Contributor

@googlebot I consent

@google-cla google-cla bot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Aug 11, 2021
@lionelvillard
Copy link
Contributor

known data race

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2021
@knative-prow-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2021
@knative-prow-robot knative-prow-robot merged commit e4c93f8 into knative-extensions:release-0.24 Aug 11, 2021
matzew pushed a commit to matzew/eventing-kafka that referenced this pull request Aug 23, 2021
@knative-prow-robot @devguyio @matzew
[release-0.24] [Consolidated KafkaChannel] Set KafkaChannel consolida…
b5db2c1 
…ted dispatcher OwenrRef (knative-extensions#802)

* Set KafkaChannel consolidated dispatcher OwenrRef

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

* Remove the rest of superficial tests

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

* Use a k8s go-client to fetch controller deployment

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

* Refactor dispatcher reconciliation logic for easier reasoning

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

* Remove apps.kubernetes.io labels

* fix bad comment

* Use apimachinary wait package instead of manual backoff

* fix typo

Co-authored-by: Ahmed Abdalla <aabdelre@redhat.com>
@matzew matzew mentioned this pull request Aug 23, 2021
Merged
openshift-merge-robot pushed a commit to openshift-knative/eventing-kafka that referenced this pull request Aug 23, 2021
@matzew @knative-prow-robot @devguyio
[0.24] Backport of upstream 802 (#318)
b4edfe7 
* [release-0.24] [Consolidated KafkaChannel] Set KafkaChannel consolidated dispatcher OwenrRef (knative-extensions#802)

* Set KafkaChannel consolidated dispatcher OwenrRef

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

* Remove the rest of superficial tests

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

* Use a k8s go-client to fetch controller deployment

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

* Refactor dispatcher reconciliation logic for easier reasoning

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

* Remove apps.kubernetes.io labels

* fix bad comment

* Use apimachinary wait package instead of manual backoff

* fix typo

Co-authored-by: Ahmed Abdalla <aabdelre@redhat.com>

* make RELEASE=v0.24.0 generate-release for regeneration of our midstream yamls

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Co-authored-by: Ahmed Abdalla <aabdelre@redhat.com>
@pierDipi pierDipi mentioned this pull request Oct 4, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@matzew matzew

@lionelvillard lionelvillard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@knative-prow-robot @devguyio @lionelvillard @matzew