这是indexloc提供的服务，不要输入任何密码
Skip to content

The Broker retries sending events #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 9, 2020
Merged

The Broker retries sending events #268

merged 5 commits into from
Oct 9, 2020

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Oct 8, 2020

Fixes #116

Proposed Changes

  • Retry sending events through the circuit breaker
  • Add E2E tests for the redelivery feature

Release Note

- 🎁 Add new feature
The Broker retries sending events.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2020
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 8, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 8, 2020
@codecov
Copy link

codecov bot commented Oct 8, 2020 •
edited
Loading

Codecov Report

Merging #268 into master will increase coverage by 0.06%.
The diff coverage is 65.51%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #268      +/-   ##
============================================
+ Coverage     76.76%   76.82%   +0.06%     
- Complexity      170      177       +7     
============================================
  Files            49       49              
  Lines          1463     1493      +30     
  Branches         46       47       +1     
============================================
+ Hits           1123     1147      +24     
- Misses          271      275       +4     
- Partials         69       71       +2
Flag Coverage Δ Complexity Δ
#java-unittests 76.20% <64.91%> (+0.15%) 177.00 <14.00> (+7.00)
#unittests 76.82% <65.51%> (+0.06%) 177.00 <14.00> (+7.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...oker/dispatcher/http/HttpConsumerRecordSender.java 53.84% <51.72%> (+12.46%) 6.00 <5.00> (+2.00)
...r/dispatcher/http/HttpConsumerVerticleFactory.java 90.47% <76.92%> (-7.26%) 13.00 <6.00> (+3.00) ⬇️
control-plane/pkg/reconciler/broker/broker.go 80.47% <100.00%> (ø) 0.00 <0.00> (ø)
...ting/kafka/broker/dispatcher/ResourcesManager.java 90.41% <100.00%> (+0.13%) 21.00 <3.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b42c78d...22d5326. Read the comment docs.

@pierDipi pierDipi force-pushed the KNATIVE-116-data-plane branch from 7ae0d24 to c01e5db Compare October 8, 2020 07:51
@pierDipi pierDipi changed the title [WIP] The Broker retries sending events The Broker retries sending events Oct 8, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2020
@pierDipi
Copy link
Member Author

pierDipi commented Oct 8, 2020

2/2 Worked, retesting
/test pull-knative-sandbox-eventing-kafka-broker-integration-tests

@slinkydeveloper
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pierDipi,slinkydeveloper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi pierDipi mentioned this pull request Oct 9, 2020
Closed
@pierDipi
The Broker retries sending events
4f2f3b8 
- Retry sending events through the circuit breaker

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi
Add E2E tests for the redelivery feature
263ccc4 
- [v1, linear]
- [v1beta1, linear]
- [v1, exponential]
- [v1beta1, exponential]

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi
Expand unit test
8dc8f74 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi
Return retryPolicy function
f856f2b 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi
Set default retry delay from configs
22d5326 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi pierDipi force-pushed the KNATIVE-116-data-plane branch from 9ddd6c9 to 22d5326 Compare October 9, 2020 10:51
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
@pierDipi
Copy link
Member Author

pierDipi commented Oct 9, 2020

Rebased.

@slinkydeveloper
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
@knative-prow-robot knative-prow-robot merged commit 6e5a17f into knative-extensions:master Oct 9, 2020
@pierDipi pierDipi deleted the KNATIVE-116-data-plane branch April 14, 2021 21:17
matzew added a commit to matzew/eventing-kafka-broker that referenced this pull request May 19, 2022
@matzew
Merge pull request knative-extensions#268 from matzew/Handle_committi…
900fb1c 
…ng_offsets_on_revoked_partitions

[release v1.2] Handle committing offsets on revoked partitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harwayne Harwayne Awaiting requested review from Harwayne

@slinkydeveloper slinkydeveloper Awaiting requested review from slinkydeveloper

Assignees

@slinkydeveloper slinkydeveloper

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support full Delivery Spec
3 participants
@pierDipi @slinkydeveloper @knative-prow-robot