这是indexloc提供的服务,不要输入任何密码
Skip to content

Remove config-logging volume and add server config for the sink #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

pierDipi
Copy link
Member

The config-logging volume mount isn't necessary.

Fixes #287

Proposed Changes

  • Remove config-logging volume and add server config for the sink

Release Note

- 🧽 Update or clean up current behavior
Remove config-logging volume from the controller

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 12, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 12, 2020
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #288 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #288   +/-   ##
=========================================
  Coverage     76.82%   76.82%           
  Complexity      177      177           
=========================================
  Files            49       49           
  Lines          1493     1493           
  Branches         47       47           
=========================================
  Hits           1147     1147           
  Misses          275      275           
  Partials         71       71           
Flag Coverage Δ Complexity Δ
#java-unittests 76.20% <ø> (?) 177.00 <ø> (?)
#unittests 76.82% <ø> (ø) 177.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c63b35...d0f8be6. Read the comment docs.

@slinkydeveloper
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pierDipi,slinkydeveloper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@slinkydeveloper
Copy link
Contributor

Good catch!

@knative-prow-robot knative-prow-robot merged commit f402fd8 into knative-extensions:master Oct 13, 2020
pierDipi added a commit to pierDipi/eventing-kafka-broker that referenced this pull request Oct 13, 2020
…ive-extensions#288)

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi pierDipi deleted the KNATIVE-287 branch April 14, 2021 21:17
pierDipi added a commit to pierDipi/eventing-kafka-broker that referenced this pull request Jun 7, 2022
…e-extensions#288)

* Commit offsets on partition revoked

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Stop executors when partitions are revoked

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Add license header

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove config-logging volume from the controller
3 participants