这是indexloc提供的服务，不要输入任何密码
Skip to content

Add HTTP Header 'Prefer: reply' in accordance with KNative specs #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2022
Merged

Add HTTP Header 'Prefer: reply' in accordance with KNative specs #1771

merged 1 commit into from
Jan 21, 2022

Conversation

jhill072
Copy link
Contributor

Fixes #

Proposed Changes

Release Note

An HTTP header will be supplied to your event consumers when the broker it is communicating with supports reply events. This will always be sent while using this Kafka broker since it supports handling reply events.

Docs

@knative-prow-robot knative-prow-robot added area/data-plane size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 20, 2022
@knative-prow-robot
Copy link
Contributor

Welcome @jhill072! It looks like this is your first PR to knative-sandbox/eventing-kafka-broker 🎉

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 20, 2022
@knative-prow-robot
Copy link
Contributor

Hi @jhill072. Thanks for your PR.

I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matzew
Copy link
Contributor

matzew commented Jan 21, 2022

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 21, 2022
@matzew
Copy link
Contributor

matzew commented Jan 21, 2022

related: https://github.com/knative/eventing/pull/5764/files

matzew
matzew approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhill072, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 21, 2022
@matzew
Copy link
Contributor

matzew commented Jan 21, 2022

@jhill072 you seem to not have a CLA in place

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2022
@jhill072
Copy link
Contributor Author

Thank you for the update @matzew ! I forgot to switch to my github email before pushing the commit, CLA should be good now.
Will keep an eye on the integraiton tests since they seemed to have failed for some weird reason.

@matzew
Copy link
Contributor

matzew commented Jan 21, 2022

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2022
@knative-prow-robot knative-prow-robot merged commit 5ba9e48 into knative-extensions:main Jan 21, 2022
@pierDipi pierDipi mentioned this pull request Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhill072 @knative-prow-robot @matzew