Handle non-retryable HTTP status codes as reported in the spec #1574
Conversation
As reported in the spec: https://github.com/knative/specs/blob/c348f501de9eb998b4fd010c54d9127033ee41be/specs/eventing/data-plane.md#event-acknowledgement-and-delivery-retry Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
Codecov Report
@@ Coverage Diff @@
## main #1574 +/- ##
============================================
- Coverage 75.35% 75.28% -0.07%
- Complexity 592 597 +5
============================================
Files 107 107
Lines 4135 4140 +5
Branches 170 171 +1
============================================
+ Hits 3116 3117 +1
- Misses 763 766 +3
- Partials 256 257 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| return statusCode >= 500 || // Generic error | ||
| statusCode == 404 || // Endpoint does not exist | ||
| statusCode == 409 || // Conflict / Processing in progress | ||
| statusCode == 429; // Too Many Requests / Overloaded |
There was a problem hiding this comment.
for completeness we have -1 there as well, in upstream ...
I guess that's due to a Golang thingy/bug... but just wanted to mention it here
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As reported in the spec:
https://github.com/knative/specs/blob/c348f501de9eb998b4fd010c54d9127033ee41be/specs/eventing/data-plane.md#event-acknowledgement-and-delivery-retry
Similar to
SelectiveRetryfunction in eventing.Proposed Changes
Release Note
Docs