这是indexloc提供的服务，不要输入任何密码
Skip to content

operator shipwright-operator (0.16.0) #6494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

operator shipwright-operator (0.16.0) #6494

wants to merge 1 commit into from

Conversation

psrvere
Copy link

@psrvere psrvere commented Jul 11, 2025 •
edited
Loading

  • Added bundle for 0.16.0

Thanks submitting your Operator. Please check below list before you create your Pull Request.

New Submissions

Updates to existing Operators

  • Did you create a ci.yaml file according to the update instructions?
  • Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description about the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

--

1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need

2 For more information see here

@openshift-ci openshift-ci bot requested review from mporrato and tomasbakk July 11, 2025 09:05
@github-actions GitHub Actions
Copy link
Contributor

@sbose78,@SaschaSchwarze0,@adambkaplan , please approve as you are original reviewer(s).

  • To add more contributors to ci.yaml follow instruction here.
  • To approve follow instruction here

@github-actions GitHub Actions
Copy link
Contributor

Dear @psrvere,
Some errors and/or warnings were found while doing the check of your operator (shipwright-operator/0.16.0) against the entire suite of validators for Operator Framework with Operator-SDK version v1.36.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type Message
⚠️ Value shipwright-operator.v0.16.0: required CRD "tektonconfigs.operator.tekton.dev" has an empty description
⚠️ Value shipwright-operator.v0.16.0: required CRD "certificates.cert-manager.io" has an empty description
⚠️ Value shipwright-operator.v0.16.0: CSV contains permissions to create CRD. An Operator shouldn't deploy or manage other operators (such patterns are known as meta or super operators or include CRDs in its Operands). It's the Operator Lifecycle Manager's job to manage the deployment and lifecycle of operators. Please, review the design of your solution and if you should not be using Dependency Resolution from OLM instead. More info: https://sdk.operatorframework.io/docs/best-practices/common-recommendation/

@psrvere psrvere force-pushed the shipwright-0.16.0 branch from dd2e575 to c882adf Compare July 11, 2025 09:25
@github-actions GitHub Actions
Copy link
Contributor

Dear @psrvere,
Some errors and/or warnings were found while doing the check of your operator (shipwright-operator/0.16.0) against the entire suite of validators for Operator Framework with Operator-SDK version v1.36.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type Message
⚠️ Value shipwright-operator.v0.16.0: CSV contains permissions to create CRD. An Operator shouldn't deploy or manage other operators (such patterns are known as meta or super operators or include CRDs in its Operands). It's the Operator Lifecycle Manager's job to manage the deployment and lifecycle of operators. Please, review the design of your solution and if you should not be using Dependency Resolution from OLM instead. More info: https://sdk.operatorframework.io/docs/best-practices/common-recommendation/

adambkaplan
adambkaplan suggested changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think I found the issue for why we have an invalid bundle

operators/shipwright-operator/0.16.0/manifests/shipwright-operator.clusterserviceversion.yaml Outdated
env:
- name: USE_MANAGED_WEBHOOK_CERTS
value: "true"
image: ko://github.com/shipwright-io/operator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@psrvere did you follow the procedure here for copying over the release manifests?

The operator bundle should resolve to real images on ghcr.io, it should not have ko:// image references.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adambkaplan - you are right. I missed the mount step and instead copied files from operator repo. Have fixed this.

@psrvere
Update Shipwright Operator to 0.16.0
4cc58c0 
  - added bundle for 0.16.0
  - added description in csv for TektonConfig and Certificate to silence warning in CI
    warning: Value shipwright-operator.v0.16.0: required CRD has an empty description

Signed-off-by: Prateek Singh Rathore <prateek.singh.rathore@gmail.com>
@psrvere psrvere force-pushed the shipwright-0.16.0 branch from c882adf to 4cc58c0 Compare July 15, 2025 11:31
@framework-automation
Copy link
Collaborator

/merge possible

@framework-automation
Copy link
Collaborator

/merge possible

@github-actions GitHub Actions
Copy link
Contributor

Current PR can be merged automatically, but there is missing authorized-changes label. One can find out more info here.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Current PR can be merged automatically, but there is missing authorized-changes label. One can find out more info here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan requested changes

@mporrato mporrato Awaiting requested review from mporrato

@tomasbakk tomasbakk Awaiting requested review from tomasbakk

Assignees

@mporrato mporrato

@Allda Allda

Labels
installation-validated package-validated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@psrvere @framework-automation @adambkaplan @mporrato @Allda