这是indexloc提供的服务,不要输入任何密码
Skip to content

Replay ball on mission completion for FT #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

miaucl
Copy link

@miaucl miaucl commented Feb 28, 2025

As metioned in #238, in the original FT build one gets a replay ball when completing a mission. I added a video of a tutorial seeing it in action.

See bottom left lite light up upon completion of mission: https://youtu.be/kjs1KB6oz_k?feature=shared&t=162

Currently it is only activated for FT, as I only found evidence for this in FT and not 3DPB. The condition has been derived from the code about the wormhole handling which either gives a replay ball for 3DPB or locks the ball for FT.

@miaucl
Copy link
Author

miaucl commented Feb 28, 2025

PS: I tried to specify it in the function MissionControl, but there was no easy way to exclude the WaitingDeployment which triggered a replay ball on every launch...
There were also some composite Missions which should not trigger a replay ball after each step.

Copy link

@RiedleroD RiedleroD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just quickly skimmed over and noticed there's some code formatting issues. No notes on the code itself, I'm not familiar enough with the codebase to comment on that.

@miaucl
Copy link
Author

miaucl commented Mar 1, 2025

Yeah I guess it is tabs vs spaces once more :)

Seud added a commit to Seud/SpaceCadetPinball that referenced this pull request Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants