这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix missing includes in options.h #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix missing includes in options.h #162

wants to merge 1 commit into from

Conversation

@Low-power
Copy link
Contributor

@Low-power Low-power commented Nov 15, 2022

I have no idea how it worked otherwise, but it failed to compile on my system (Debian 9):

In file included from SpaceCadetPinball/Sound.cpp:1:0:
SpaceCadetPinball/options.h:96:7: error: ‘string’ in namespace ‘std’ does not name a type
SpaceCadetPinball/options.h:114:35: error: ‘MIX_MAX_VOLUME’ was not declared in this scope
SpaceCadetPinball/options.h:120:21: error: ‘LPCSTR’ has not been declared
SpaceCadetPinball/options.h:121:22: error: ‘LPCSTR’ has not been declared
SpaceCadetPinball/options.h:122:14: error: ‘string’ in namespace ‘std’ does not name a type
SpaceCadetPinball/options.h:123:25: error: ‘LPCSTR’ has not been declared
SpaceCadetPinball/options.h:123:45: error: ‘LPCSTR’ has not been declared
SpaceCadetPinball/options.h:124:25: error: ‘LPCSTR’ has not been declared
SpaceCadetPinball/options.h:125:24: error: ‘LPCSTR’ has not been declared
SpaceCadetPinball/options.h:126:34: error: ‘string’ in namespace ‘std’ does not name a type
SpaceCadetPinball/options.h:127:34: error: ‘string’ in namespace ‘std’ does not name a type
SpaceCadetPinball/options.h:134:14: error: ‘map’ in namespace ‘std’ does not name a template type
SpaceCadetPinball/options.h:140:34: error: ‘ImGuiContext’ has not been declared
SpaceCadetPinball/options.h:140:53: error: ‘ImGuiSettingsHandler’ has not been declared
SpaceCadetPinball/options.h:141:15: error: expected ‘;’ at end of member declaration
SpaceCadetPinball/options.h:141:47: error: expected ‘)’ before ‘*’ token
SpaceCadetPinball/options.h:142:34: error: ‘ImGuiContext’ has not been declared
SpaceCadetPinball/options.h:142:53: error: ‘ImGuiSettingsHandler’ has not been declared
SpaceCadetPinball/options.h:142:84: error: ‘ImGuiTextBuffer’ has not been declared
SpaceCadetPinball/options.h:143:20: error: ‘string’ in namespace ‘std’ does not name a type
SpaceCadetPinball/options.h:144:36: error: ‘string’ in namespace ‘std’ does not name a type
SpaceCadetPinball/options.h:144:60: error: ‘string’ in namespace ‘std’ does not name a type

@Low-power Low-power mentioned this pull request Nov 15, 2022
Merged
@Low-power Low-power force-pushed the fix-missing-includes branch from 827340e to e548a89 Compare November 17, 2022 06:50
@k4zmu2a
Copy link
Owner

k4zmu2a commented Nov 17, 2022

Instead of the hack in options.h try putting pch include on the first line in Sound.cpp.
Like this:
#include "pch.h"
#include "options.h"
...

k4zmu2a added a commit that referenced this pull request Nov 21, 2022
@k4zmu2a
Reordered pch includes in Sound.
1391eeb 
This might help with #162.
Fixed switch warning.
@Low-power
Copy link
Contributor Author

Low-power commented Nov 23, 2022

I can confirm that this bug has been fixed by 1391eeb.

@Low-power Low-power closed this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Low-power @k4zmu2a