-
Notifications
You must be signed in to change notification settings - Fork 264
Add translations #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translations #153
Conversation
|
Hello. This translations step 1 looks pretty good to me. Here are my usual nitpicks: That is all for this review. |
|
About the macro, I think I can use InitializedArray to have the display name associated with the language enums.
|
MSVC will read the file as ASCII and reconvert characters as UTF-8, this will corrupt characters as the file is in fact already in UTF-8.
Fallback to english if available, else return empty string
b3a460a to
dc828b0
Compare
|
I believe there is a miscommunication happening here. |
Removed unused Msg entries and added new check.
|
This PR is now aligned with my vision™)) One last thing for you to do before the merge: |
|
Thanks for your changes, I've done the removal of English texts for non-English languages. |
|
Alright, this PR is now good to go. Up next - my plans for localization support v1: |
Hi,
Here is the PR to add translations as discussed in #152.
I've used the C++11 version as there is no significant performance impact (I've checked with valgrind that the initialization doesn't use much cpu time).
I've also added a when to change the font, this is required to display characters that the default font doesn't support.
For that, I use the current language to construct the font atlas with only needed characters.
When using a non-default font, text is not as good, but I can't make it better. I think subpixel rendering is what is needed, but ImGui doesn't support it (yet).
Fixes: #152