-
Notifications
You must be signed in to change notification settings - Fork 264
updated Icon_1.ico with 256x256 render for modern Windows using IcoFX #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello Adam. This PR is a great idea - having upscaled icons for Linux, using them for Windows makes sense. In my tests, your .ico file failed to render at x265 when baked into an exe (on both win10 and 11). |
|
Here is a build after PR merge, for you to check if this new icon works as expected: This build is quite close to 2.1.0Rel, one might even call it RC) |
|
I've seen similar issues with the windows icon cache too, typically just renaming the .exe to something different will show you the correct icon as a quick workaround until it catches up/refreshes manually. I'm sure theres a way to reload the cache quickly but I havent figured that out just yet You mention 265 in your reply I guess you meant 256 (i dont know what would happen if you tried to load a 265x265 icon!) I'm really happy this idea works and is accepted! thanks I've checked your exe and the icon works great, I'm unable to play the game with it though (using default pinball files and the x86 sdl files), load error here: |
|
The adjusted icon works as indented, that is good news. You are very welcome. |
FYI The file you attached looked even older (v2.0.1-rc e.g its missing the 256px icon) that the last one (v2.1.0-dev). I've tried lots of cominations of .exe and .dll with no luck |
|
Yep, that was indeed some old RC build, foiled again by Win11 UI. |
|
works like a treat, nice one! |
Hi K4zmu2a, I love your work! this PR is to update the embedded windows .ico file to support the modern/larger 256x256 format. Example here (left-to-right: current, new, and firefox for reference)
For your info, i'll outline the steps used to create this icon (per my installer repo):
My understanding is my accepting this PR will mean future compilations of your source into .exe format will automatically pick up and utilise these changes (really looking forward to 2.1.0 whenever it ships!).
Note: this is my first ever public PR 🤞 I hope it's a worthy addition!
thank you,
Adam