patch: fix build error "[vite-plugin-top-level-await] Bindings not found" #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
According to https://caniuse.com/mdn-javascript_operators_await_top_level, it seems that browser versions from 2021 and later have support for top-level await. I think the scope is too narrow, I would like to keep the current version to support more browser versions, because the webui of rwkv-runner needs to consider its use by ordinary users, some of whom may have older devices. |
49092fa to
16d8c57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
top-level await is supported by current browser, we may just skip this plugin.
(I install the dependencies with pnpm instead of npm, not sure if it is related)