Get PR 343 working #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
335b2a3 to
fa89730
Compare
f7b039c to
02d4729
Compare
jorisvandenbossche
pushed a commit
that referenced
this pull request
Apr 23, 2022
* geopandas/issues/2350 * resolve items raised in review #1 * new version of black... * improve code readability * Apply suggestions from code review Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm having a look at all of the overlay related pull requests, and thought I'd start with this one. Although I have noted the comments in geopandas#338 I think it's worthwhile to either merge or kill these old PR's.
This works for me, locally and on Travis-CI.