fix segfault from freeaddrinfo on hints #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looking into it even further, hunch seems to be right... we're allocating memory for the |
Owner
|
Thanks for this pull request - I added a bit of documentation to it (and added some improved diagnostics while I was in there), which is covered in #6. This has been pulled into master. |
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were receiving segfaults regularly on reload, and I finally tracked it down to this line. A coworker, Jason, figured it had something to do with the fact that the hints' addrinfo struct wasn't complete (and doesn't need to be) and therefore who knows what's going on in
freeaddrinfo(), but it wasn't happy. So we zeroed out hints (doesn't seem to matter where - anywhere between themalloc()andfreeaddrinfo()works) and sure enough, the segfaults stopped.