fix some memory issues #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* getaddrinfo is alread allocating the addrinfo struct so we get a (quiet small) memory hole * now checking if malloc failed for whatever reason * TODO if I startup a varnish and put all traffic at once on it the freeaddrinfo is failing (in libjemalloc/jemalloc_linux.c) and I don't know why. Probably this is a bug in the libjemalloc but I'm not sure about that.
Owner
|
Thanks for your contribution - merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(quiet small) memory hole
take all available memory when having a connect failure on each
statsd call)
freeaddrinfo is failing (in libjemalloc/jemalloc_linux.c) and I
don't know why. Probably this is a bug in the libjemalloc but I'm
not sure about that, maybe it is a problem with multithreading (many
of them tries to connect but a fprintf() debugging doesn't show
something like that)..