-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Myanmar i18n #8317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Myanmar i18n #8317
Conversation
|
Thanks a lot @pmverma ! I know this is a lot of work. |
|
Thank you @jdubois . Happy to contribute. JHipster and its people are just awesome. |
|
Thanks for your kind words @pmverma - but nothing could be done without contributors like you! |
|
@jdubois Not sure why the However, as we can see here that travis is failing because entity i18n was not generated. I will check this tomorrow by running travis locally. |
|
@pmverma I've restarted Travis, just in case (it's sometimes a bit unstable) |
|
@jdubois Build is failing again. It is sure something is wrong with i18n generation. I also tried to run |
|
@pmverma You need to add |
|
@ruddell Oh thank you. I just couldn't find it that time. |
|
@jdubois Can you please restart the build again? This time it seems the build error of itself. |
|
@pmverma Restarted the failing test. |
|
@pmverma : can you do a PR against https://github.com/jhipster/jhipster.github.io plz plz? |
I would like to propose a PR for adding Myanmar i18n.
I have translated most parts except some administration pages which I think better to keep it as it is due to usability.
I will also update the documentation soon.
Please make sure the below checklist is followed for Pull Requests.
Travis tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed