这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@pmverma
Copy link
Member

@pmverma pmverma commented Sep 13, 2018

I would like to propose a PR for adding Myanmar i18n.
I have translated most parts except some administration pages which I think better to keep it as it is due to usability.

I will also update the documentation soon.

  • Please make sure the below checklist is followed for Pull Requests.

  • Travis tests are green

  • Tests are added where necessary

  • Documentation is added/updated where necessary

  • Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

@jdubois
Copy link
Member

jdubois commented Sep 13, 2018

Thanks a lot @pmverma ! I know this is a lot of work.

@pmverma
Copy link
Member Author

pmverma commented Sep 13, 2018

Thank you @jdubois . Happy to contribute. JHipster and its people are just awesome.

@jdubois
Copy link
Member

jdubois commented Sep 13, 2018

Thanks for your kind words @pmverma - but nothing could be done without contributors like you!

dont-try-to-deny-it-awesome-meme

@pmverma
Copy link
Member Author

pmverma commented Sep 14, 2018

@jdubois Not sure why the entityxxxxx.json is not generated.
I have added entity i18n at 5995ffb#diff-67ac5a3ba64eac15dfa7162957d7abf8

However, as we can see here that travis is failing because entity i18n was not generated.
https://travis-ci.org/jhipster/generator-jhipster/jobs/428212796#L1553

I will check this tomorrow by running travis locally.

@jdubois
Copy link
Member

jdubois commented Sep 14, 2018

@pmverma I've restarted Travis, just in case (it's sometimes a bit unstable)

@pmverma
Copy link
Member Author

pmverma commented Sep 14, 2018

@jdubois Build is failing again. It is sure something is wrong with i18n generation.

I also tried to run travis/build_sample.sh build but it is failing due to some couchbase cluster which I am not familiar much.
Let me check entity generator code.

@ruddell
Copy link
Member

ruddell commented Sep 14, 2018

@pmverma entity.spec.js is failing, you can test locally with npm run test:unit test/entity.spec.js from the root of generator-jhipster

You need to add my to the list in this file for the test to pass.

@pmverma
Copy link
Member Author

pmverma commented Sep 15, 2018

@ruddell Oh thank you. I just couldn't find it that time.

@pmverma
Copy link
Member Author

pmverma commented Sep 16, 2018

@jdubois Can you please restart the build again? This time it seems the build error of itself.

@DanielFran
Copy link
Member

@pmverma Restarted the failing test.

@ruddell ruddell merged commit 0afe3f9 into jhipster:master Sep 16, 2018
@pascalgrimaud
Copy link
Contributor

@pmverma : can you do a PR against https://github.com/jhipster/jhipster.github.io plz plz?

@jdubois jdubois added this to the 5.3.2 milestone Sep 17, 2018
@pmverma pmverma deleted the my-i18n branch January 24, 2019 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants