这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@geraldhumphries
Copy link
Contributor

switch user-management page and entity generator to using UI Bootstrap's
pagination and pager directives

fix #1374

@geraldhumphries
Copy link
Contributor Author

UI Bootstrap's pagination is 1-indexed which is why the page variables were changed to 1.

I have tried out the entity generator and generated a full app (for user management) and ran Mocha tests but I have not tested out Cassandra! I have a feeling that the X-Total-Count header might be empty and could break something.

@geraldhumphries
Copy link
Contributor Author

After #2389 is merged in, this will need to be modified (or vice-versa)

switch user-management page and entity generator to using UI Bootstrap's
pagination and pager directives

fix jhipster#1374
@geraldhumphries
Copy link
Contributor Author

Translations have not been done, but can be added with filters:

previous-text="{{ 'global.pager.previous' | translate }}" next-text="{{ 'global.pager.next' | translate }}"

I have left them out for now and made the buttons « and » because adding new messages means updating ALL the languages.

@geraldhumphries
Copy link
Contributor Author

Something seems to be wrong with Travis. The first build failed for something that didn't appear to be related to the code, so I closed and reopened the pull request to make it run again. It gave a different error. Any thoughts?

@jdubois
Copy link
Member

jdubois commented Nov 25, 2015

@geraldhumphries Travis had a timeout, I just ran it again

@deepu105
Copy link
Member

We should remove the unused directives and their html files

@deepu105
Copy link
Member

@geraldhumphries #2389 is merged can you plz update this as well?

@geraldhumphries
Copy link
Contributor Author

Updated with the new names, removed the unused directives and templates, and fixed conflict.

@deepu105
Copy link
Member

+1

… into bootstrap-pagination

Conflicts:
	app/templates/src/main/webapp/scripts/app/admin/user-management/_user-management.controller.js
@deepu105
Copy link
Member

have someone tested this with cassandra?

@jdubois
Copy link
Member

jdubois commented Dec 1, 2015

@deepu105 I'm going to test this with Cassandra

@jdubois
Copy link
Member

jdubois commented Dec 1, 2015

Works great! Also tested with MongoDB

jdubois added a commit that referenced this pull request Dec 1, 2015
@jdubois jdubois merged commit 7735b1d into jhipster:master Dec 1, 2015
@jdubois jdubois modified the milestone: 2.25.0 Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why entity generator don't use pagination directive?

3 participants