-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
switch to UI Bootstrap's pagination #2402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
UI Bootstrap's pagination is 1-indexed which is why the page variables were changed to 1. I have tried out the entity generator and generated a full app (for user management) and ran Mocha tests but I have not tested out Cassandra! I have a feeling that the |
|
After #2389 is merged in, this will need to be modified (or vice-versa) |
switch user-management page and entity generator to using UI Bootstrap's pagination and pager directives fix jhipster#1374
346cd07 to
d857d95
Compare
|
Translations have not been done, but can be added with filters:
I have left them out for now and made the buttons |
|
Something seems to be wrong with Travis. The first build failed for something that didn't appear to be related to the code, so I closed and reopened the pull request to make it run again. It gave a different error. Any thoughts? |
|
@geraldhumphries Travis had a timeout, I just ran it again |
|
We should remove the unused directives and their html files |
|
@geraldhumphries #2389 is merged can you plz update this as well? |
… into bootstrap-pagination Conflicts: entity/templates/src/main/webapp/app/_entity-controller.js
|
Updated with the new names, removed the unused directives and templates, and fixed conflict. |
|
+1 |
… into bootstrap-pagination Conflicts: app/templates/src/main/webapp/scripts/app/admin/user-management/_user-management.controller.js
|
have someone tested this with cassandra? |
|
@deepu105 I'm going to test this with Cassandra |
|
Works great! Also tested with MongoDB |
switch to UI Bootstrap's pagination
switch user-management page and entity generator to using UI Bootstrap's
pagination and pager directives
fix #1374