-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
add create user and delete user feature #2385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to differentiate here between mongo/sql and cassandra. Cassandra requires a plain java.util.Date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @atomfrede
|
I tested this for SQL and looks good, if everyone is ok I'll merge this |
|
Is there also a possibility to just (temporarly) deactivate the user? |
|
No this feature includes only deletion of user. Temporary deactivation can be done via edit screen right? |
|
Yes, I was not sure if it is implemented there. |
|
Yes it is available in both listing screen and edit screen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2389 is merged hence plz update to uibModalInstance
de08fb7 to
5da1621
Compare
|
Great feature, I just tried it and I have a few issues to be solved before we can merge this:
|
5da1621 to
5c264b0
Compare
always throws empty alert. Try simulating the same in any generated entity. I would suggest we can write a custom header util for this kind of custom alerts. |
|
I guess its ok to write additional HeaderUtil methods for such validation errors |
83f6074 to
8dedcbb
Compare
|
@jdubois resolved all the issues listed and it is ready to merge |
|
@jdubois Please let me know if you have any more comments. Updated Code base based on romanian lang |
f8ffa71 to
9d1b5a8
Compare
|
Great work!! I am going to merge this ASAP:
|
|
I have merged this manually so I'm closing this -> strange that Github does not show this as "merged", if you see any error please ping me! |
Admin - Create User :
when a new user is created, reset key and date will be generated and mail will be triggered. Users upon clicking the link, system will ask them to reset the password. By default, Users created via backend will always be activated.
Admin - Delete User :
User will be hard deleted.
fix #2374