这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@sendilkumarn
Copy link
Member

Admin - Create User :
when a new user is created, reset key and date will be generated and mail will be triggered. Users upon clicking the link, system will ask them to reset the password. By default, Users created via backend will always be activated.
Admin - Delete User :
User will be hard deleted.

fix #2374

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to differentiate here between mongo/sql and cassandra. Cassandra requires a plain java.util.Date

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atomfrede

@deepu105
Copy link
Member

I tested this for SQL and looks good, if everyone is ok I'll merge this

@atomfrede
Copy link
Member

Is there also a possibility to just (temporarly) deactivate the user?

@sendilkumarn
Copy link
Member Author

No this feature includes only deletion of user.

Temporary deactivation can be done via edit screen right?

@atomfrede
Copy link
Member

Yes, I was not sure if it is implemented there.

@sendilkumarn
Copy link
Member Author

Yes it is available in both listing screen and edit screen.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2389 is merged hence plz update to uibModalInstance

@jdubois
Copy link
Member

jdubois commented Nov 27, 2015

Great feature, I just tried it and I have a few issues to be solved before we can merge this:

  • The "create a new user" button is not at the right place -> can you use the same layout as what we have with the entity generator?
  • If we use an existing email address, and error will occur -> the error is not displayed correctly on the screen, there is just an alert box with no text, and it is not cleanly displayed
  • When creating a new user, even if I select the "ROLE_USER" authorization, the user does not have that authorization. I need to edit the user, add the authorization again, and then it works.
  • Deleting a user does not work, I have a ReferenceError: $uibModal is not defined error in my browser -> that might come from some of our recent changes, not your fault

@sendilkumarn
Copy link
Member Author

@jdubois

for If we use an existing email address, and error will occur -> the error is not displayed correctly on the >screen, there is just an alert box with no text, and it is not cleanly displayed

ResponseEntity.badRequest().headers("alert" "param")).body(null);

always throws empty alert. Try simulating the same in any generated entity. I would suggest we can write a custom header util for this kind of custom alerts.

@deepu105
Copy link
Member

I guess its ok to write additional HeaderUtil methods for such validation errors

@sendilkumarn
Copy link
Member Author

@jdubois resolved all the issues listed and it is ready to merge

@sendilkumarn
Copy link
Member Author

@jdubois Please let me know if you have any more comments.

Updated Code base based on romanian lang

@jdubois
Copy link
Member

jdubois commented Dec 1, 2015

Great work!!
I have also tested this with Cassandra and MongoDB

I am going to merge this ASAP:

  • I'm waiting for Travis CI to do all the automated checks
  • I'm going to rename some translation keys as they are not correct (but this isn't your fault!)

@jdubois
Copy link
Member

jdubois commented Dec 1, 2015

I have merged this manually so I'm closing this -> strange that Github does not show this as "merged", if you see any error please ping me!

@jdubois jdubois closed this Dec 1, 2015
@jdubois jdubois modified the milestone: 2.25.0 Dec 4, 2015
@sendilkumarn sendilkumarn deleted the user-update branch October 21, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[enhancement] Add / Delete Users by Admin Users

4 participants