prevent leakage of user information via api #22373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82081d8 to
6684d4a
Compare
Member
Author
|
Will check the failing tests later today. Seems to have something to do with microservices. |
f121b7f to
d57cf7a
Compare
Member
Author
|
Don't know whats the remaining issue with the failing test as gradle does not print the failing assertation. I have again issues setting up my development setup, can't generate any applications right now :( Not nice, but I adapted the assertion to both possible results. |
d57cf7a to
83b3606
Compare
83b3606 to
8264ec3
Compare
DanielFran
approved these changes
Jun 3, 2023
Member
Author
Member
|
@atomfrede approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
For imperative and reactive during registration we do not expose an error (e.g. username already exists) via the api. Therefore for the caller successful registration and failed registration look the same, so there is no way (except some sophisticated things like measuring response times) to gain knowledge about existing users and emails.
Second thing is only for reactive as for imperative spring security already took care of it.
In case authentication fails we do not expose the exact error to the caller/the api (e.g. invalid password) as this would also reveal that the login was correct. The generic error now only states
Invalid credentialswhich is the same for non reactive apps.closes #21731
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.