这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@aneri90
Copy link
Contributor

@aneri90 aneri90 commented Aug 3, 2022

This PR fixes 2 issues present when generating an application with MS SqlServer as test database.

  1. public class defined inside MsSqlTestContainer.java differs from its filename (resulting in compile errors)
  2. MSSQLServerContainer provided by org.testcontainers does not support withDatabaseName() method (resulting in a UnsupportedOperationException during tests runtime)

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

…/src/test/java/package/config/MsSqlTestContainer.java.ejs

Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
@mshima mshima enabled auto-merge (squash) August 3, 2022 16:46
@mshima mshima merged commit bbf2295 into jhipster:main Aug 3, 2022
@aneri90 aneri90 deleted the fix-mssqlserver-tests branch August 4, 2022 11:26
@DanielFran DanielFran added this to the 7.9.3 milestone Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants