Upgrade to spring-boot 1.5.9 and mapstruct to 1.2.0.Final #6782
Conversation
|
Align versions with jhipster-dependencies 0.1.0: upgrade spring-boot to 1.5.9 jhipster/jhipster-dependencies#23 |
|
FYI we’ll also need some changes to adapt to new Hazelcast when jhipster-dependencies is released with the new spring-platform and spring-boot. I have those figured out already. |
|
@DanielFran Maybe you should change the title of this PR, it's more about upgrading spring-platform / spring-boot right? Of course this PR has to wait until a new release of jhipster-dependencies is out with those changes in, and then it will be 0.1.1 or 0.2.0. |
erikkemperman
left a comment
There was a problem hiding this comment.
This looks solid, although I would have probably separated the spring-boot and mapstruct upgrades in two PRs.
But this can't be merged (nor tested) until this PR in jhipster-dependencies is merged and released:
jhipster/jhipster-dependencies#23
And at that point the version of jhipster-dependencies will have to be incremented in this branch here.
|
In fact, this was my intention to have 2 different PR but since I am a noob with git (it is my 2nd time I use it, both with jhipster projects), this has been merged in 1. This is why initially the name was only about mapstruct... |
|
@DanielFran : no worry, don't hesitate to ask advice, reviews etc. Thanks and congrats for your 1st contribution ! |
|
All right, it looks like jhipster-dependencies is now released at 0.1.4 with the platform upgrade in it: But to work in the generator, we'll also need a patch to accommodate the new Hazelcast version. If you want to copy/paste, please feel free, I've got the needed changes here: |
|
Thanks @erikkemperman - I didn't see your comment yesterday, but that's all merged now, so it should be good |
See http://mapstruct.org/news/2017-10-18-mapstruct-1_2_0_Final-is-out/
Please make sure the below checklist is followed for Pull Requests.
Travis tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed