Imaginary 13's were twice in the code #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now only 7 tests fail. Revolutionary!
Contributor
|
Dude, don't worry, they're just imaginary! |
Collaborator
|
Rebase |
In modern Yiddish the "niqqud" (diacritical marks) are optional (ref http://blogs.yiddish.forward.com/yiddish-with-an-aleph/) We shouldn't miss this vital opportunity to catch a 13.
adds square.of 13
Support nonorthogonal Yiddish
Contributor
|
I don't see anything. Are you sure this isn't your imaginary friend? |
Contributor
Author
|
Rebased and ensured that this in fact is a big issue in the code right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were putting imaginary 13's twice into this this list.
This is clearly suboptimal for this performance critical package.